[AVRO-2262] Java compression codec improvements

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.2
• Fix Version/s: 1.9.0
• Component/s: java
• Assignee: Jacob Tolar
• Reporter: Fokko Driesprong
• Created: 12/Nov/18 11:17
• Updated: 12/Nov/18 20:05
• Resolved: 12/Nov/18 11:18

Description

• Update a few things to use try-with-resources
• Updated CodecFactory to reference constants for codec names
• Fixed a small bug in Snappy and BZip2: compression/decompression were incorrect if the input ByteBuffer was a a slice(). I don't see anywhere that this would actually happen currently, but some codecs were written to account for this correctly; now they're all correct. Updated everything to compute the correct offset into the underlying array. (I can add a test for this in TestAllCodecs once #351 is merged).

Issue Links

• links to: GitHub Pull Request #352
• links to: GitHub Pull Request #376