Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-1828

Add EditorConfig file

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.8.0
    • None
    • None
    • None

    Description

      I was working with Apache Flink last week and they recently implemented http://editorconfig.org/ ( see here https://github.com/apache/flink/blob/master/.editorconfig )

      Essentially this is a very simple config file that instructs a great many editors to adhere to the main coding standard choices (things like character encoding, tabs v.s. spaces , newlines, etc) for a specific project on a per file type basis.

      When someone opens the project in a intelliJ then this will automatically use these settings.

      Proposal:

      1. We implement this for Avro at the root level with global defaults.
      2. We implement a specific file per language. I think we should start with the top level scripting (like build.sh and pom.xml) and Java as the first language.
      3. We fix the violations of this standard in a single commit per language. Note that if we don't fix those violations then later commits will be 'harder' to keep clean (you will see a lot of unrelated changes) because the IDEs will 'enforce' the standard on all touched files.

      What do you guys think?

      Attachments

        1. AVRO-1828-2016-04-28.patch
          854 kB
          Niels Basjes
        2. AVRO-1828-2016-04-28-ratfix.patch
          855 kB
          Niels Basjes

        Issue Links

          Activity

            People

              nielsbasjes Niels Basjes
              nielsbasjes Niels Basjes
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: