[AVRO-1642] JVM Spec Violation 255 Parameter Limit Exceeded

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.7.7
• Fix Version/s: 1.8.1
• Component/s: java
• Labels: build maven specific

Environment

Windows/Linux all Java

• Tags: JVM Spec Violation
• Assignee: Barry Jones
• Reporter: Bryce Alcock
• Created: 24/Feb/15 19:42
• Updated: 02/Feb/17 23:38
• Resolved: 09/Apr/16 23:10

Description

The JVM Spec indicates that:

The number of method parameters is limited to 255 by the definition of a method descriptor (§4.3.3), where the limit includes one unit for this in the case of instance or interface method invocations. Note that a method descriptor is defined in terms of a notion of method parameter length in which a parameter of type long or double contributes two units to the length, so parameters of these types further reduce the limit.

Avro Generated Java code with say more than 255 fields will create a constructor that is not valid and won't compile.

Simple test is to create a 256 field avro schema, use the avro-maven auto code gen plugin, and try to compile the resulting class.

DON'T use linux when doing this use windows, my suspicion is that Linux JavaC generates invalid byte code but does not complain.
Windows will correctly complain indicating that you are a violator of the JVM specification.

Issue Links

• supercedes: AVRO-1822 Move TestSpecificCompiler from org.apache.avro.compiler to org.apache.avro.compiler.specific to access protected members
• links to: GitHub Pull Request #192