Uploaded image for project: 'Avro'
  1. Avro
  2. AVRO-1297

NettyTransceiver: Provide overloaded close(boolean awaitCompletion)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.4
    • Fix Version/s: 1.7.5
    • Component/s: java
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In some cases clients may wish to close a NettyTransceiver without waiting for the close operation to complete, such as when the client knows that the server is dead. There should be an overloaded version of the close() method that takes the awaitCompletion flag and passes it to disconnect(boolean,boolean,Throwable).

      1. AVRO-1297.patch
        1 kB
        James Baldassari

        Activity

        Hide
        jbaldassari James Baldassari added a comment -

        Patch attached.

        Show
        jbaldassari James Baldassari added a comment - Patch attached.
        Hide
        cutting Doug Cutting added a comment -

        +1 This looks reasonable to me.

        Show
        cutting Doug Cutting added a comment - +1 This looks reasonable to me.
        Hide
        jbaldassari James Baldassari added a comment -

        Thanks, Doug. OK to commit this? Would you like to do it or shall I?

        Show
        jbaldassari James Baldassari added a comment - Thanks, Doug. OK to commit this? Would you like to do it or shall I?
        Hide
        jbaldassari James Baldassari added a comment -

        Any chance we can get this minor change into trunk soon?

        Show
        jbaldassari James Baldassari added a comment - Any chance we can get this minor change into trunk soon?
        Hide
        cutting Doug Cutting added a comment -

        Please feel free to commit this. Thanks!

        Show
        cutting Doug Cutting added a comment - Please feel free to commit this. Thanks!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1503095 from jbaldassari@apache.org in branch 'avro/trunk'
        [ https://svn.apache.org/r1503095 ]

        AVRO-1297. NettyTransceiver: Provide overloaded close(boolean awaitCompletion)

        Submitted by:jbaldassari
        Reviewed by:cutting

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1503095 from jbaldassari@apache.org in branch 'avro/trunk' [ https://svn.apache.org/r1503095 ] AVRO-1297 . NettyTransceiver: Provide overloaded close(boolean awaitCompletion) Submitted by:jbaldassari Reviewed by:cutting
        Hide
        jbaldassari James Baldassari added a comment -

        Thanks. Committed.

        Show
        jbaldassari James Baldassari added a comment - Thanks. Committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in AvroJava #384 (See https://builds.apache.org/job/AvroJava/384/)
        AVRO-1297. NettyTransceiver: Provide overloaded close(boolean awaitCompletion)

        Submitted by:jbaldassari
        Reviewed by:cutting (jbaldassari: rev 1503095)

        • /avro/trunk/CHANGES.txt
        • /avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/NettyTransceiver.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in AvroJava #384 (See https://builds.apache.org/job/AvroJava/384/ ) AVRO-1297 . NettyTransceiver: Provide overloaded close(boolean awaitCompletion) Submitted by:jbaldassari Reviewed by:cutting (jbaldassari: rev 1503095) /avro/trunk/CHANGES.txt /avro/trunk/lang/java/ipc/src/main/java/org/apache/avro/ipc/NettyTransceiver.java

          People

          • Assignee:
            jbaldassari James Baldassari
            Reporter:
            jbaldassari James Baldassari
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development