Uploaded image for project: 'Aurora'
  1. Aurora
  2. AURORA-997

ReviewBot is a filthy liar

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • None
    • 0.7.0
    • Testing
    • None

    Description

      ReviewBot was changed in https://reviews.apache.org/r/28452/ to tee output, and in doing so, builds are always marked green.

      The culprit is this command, which does not return non-zero if build.sh returns non-zero:

      bash -c ./build-support/jenkins/build.sh 2>&1 | tee foo
      

      Attachments

        Activity

          People

            wfarner Bill Farner
            wfarner Bill Farner
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: