[AURORA-800] consider using Guava's CycleDetectingLockFactory

• Type: Story
• Status: Resolved
• Priority: Critical
• Resolution: Won't Fix
• Component/s: Reliability, Scheduler
• Assignee: Unassigned
• Reporter: Kevin Sweeney
• Created: 07/Oct/14 00:52
• Updated: 28/Dec/15 02:23
• Resolved: 28/Dec/15 02:23

Description

Occasional scheduler deadlock bugs would have benefited from proactive detection. Guava provides a utility class, CycleDetectingLockFactory, which is well-suited to this task.

Keeping with our general practice of leaving all assertions enabled at runtime unless data suggests performance is impacted, I propose replacing almost all usage of the synchronized keyword or a ReentrantReadWriteLock with a CycleDetectingLockFactory-managed variant unless we have data to suggest performance would be adversely impacted.

Issue Links

• is related to: AURORA-801 deadlock in scheduler startup