Uploaded image for project: 'Aurora'
  1. Aurora
  2. AURORA-707

refactor thermos TaskRunner/Process to be more testable

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Testing, Thermos
    • Labels:
      None

      Description

      Right now Thermos is mostly tested via an integration test suite. We recently found a bug in Thermos's TaskRunner method collect_updates that should be trivially unit-testable but it's fairly challenging to mock everything in a sane way.

      A few things that would be valuable:

      • abstract out the checkpoint log – right now TaskRunnerHelper is a mishmash of checkpoint log logic and posix process handling logic.
      • remove the task lifecycle logic from TaskRunnerHelper and put somewhere else
      • invert the Process/Platform abstraction in order to make it easier to stub out Process (e.g. PosixProcess, ThreadProcess, TestProcess, DockerProcess.)
      • move the pid handling logic from TaskRunnerHelper into PosixProcess

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                wickman Brian Wickman
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: