Uploaded image for project: 'Aurora'
  1. Aurora
  2. AURORA-1951

UI build broken in gradle 4.2

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.19.0
    • None
    • None

    Description

      The recent upgrade to gradle 4.2 has broken the previously working ui build. It was a bit of a nightmare for me to get this working originally and unfortunately I don't have the bandwidth to bisect the changelog to see what they've changed.

      Here is the symptom of a false positive result:

      $ ./gradlew --rerun-tasks ui:lint
      
      BUILD SUCCESSFUL in 8s
      3 actionable tasks: 3 executed
      apache-aurora$ cd ui
      ui$ 
      ui$ npm run lint
      
      > apache-aurora@1.0.0 lint /Users/dmclaughlin/t/apache-aurora/ui
      > eslint src/main/js --ext .js
      
      
      /Users/dmclaughlin/t/apache-aurora/ui/src/main/js/components/Icon.js
        3:7  error  'test' is assigned a value but never used  no-unused-vars
      
      ✖ 1 problem (1 error, 0 warnings)
      

      I'm not totally sure which version of Gradle causes the regression.

      I also saw issues with changing files and Gradle still considering the task UP-TO-DATE. This would cause false positives in other ways and general make it unpleasant to work in the UI.

      Attachments

        Activity

          People

            wfarner Bill Farner
            davmclau David McLaughlin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: