[AURORA-1327] MesosSchedulerImpl should check if reason is present when posting status updates

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.0
• Component/s: Scheduler
• Sprint: Twitter Aurora Q2'15 Sprint 6
• Story Points: 2
• Assignee: Bill Farner
• Reporter: Joshua Cohen
• Created: 20/May/15 18:44
• Updated: 20/Jul/15 16:43
• Resolved: 01/Jul/15 17:53

Description

We export stats based on task statuses, however since protobuf enums default to a value when unset, the reason stats we generate may not be correct. c.f https://github.com/apache/aurora/blob/998993dd802cf5e94a995aefd7a6c4ec90a1d3af/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java#L228. If reason is unset, it will default to the first enum value (REASON_COMMAND_EXECUTOR_FAILED).

We should call status.hasReason() first and if it's not set, do not use the value of status.getReason().