[AURORA-1305] MemTaskStore: items are not removed from secondary index

• Type: Story
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.8.0
• Component/s: Scheduler
• Sprint: Twitter Aurora Q2'15 Sprint 2
• Story Points: 2
• Assignee: Bill Farner
• Reporter: Bill Farner
• Created: 05/May/15 20:22
• Updated: 07/May/15 17:43
• Resolved: 06/May/15 17:29

Description

An updated PMD flagged this bug (see output below).

This line:

index.remove(key, task);

should be:

index.remove(key, Tasks.id(task));

Code	Warning
GC	org.apache.aurora.scheduler.storage.entities.IScheduledTask is incompatible with expected argument type String in org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex.remove(IScheduledTask)
Bug type GC_UNRELATED_TYPES (click for details) 
In class org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex
In method org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex.remove(IScheduledTask)
Actual type org.apache.aurora.scheduler.storage.entities.IScheduledTask
Expected String
Called method com.google.common.collect.Multimap.remove(Object, Object)
Invoked on org.apache.aurora.scheduler.storage.mem.MemTaskStore$SecondaryIndex.index
task passed as argument
org.apache.aurora.scheduler.storage.entities.IScheduledTask.equals(Object) used to determine equality
At MemTaskStore.java:[line 399]

Issue Links

• blocks: AURORA-1306 Upgrade to gradle 2.4