[AURORA-1201] auth_module is not installed in child injector

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.8.0
• Component/s: Scheduler, Security
• Epic Link: Scheduler Security
• Sprint: Twitter Aurora Q1'15 Sprint 5
• Story Points: 2
• Assignee: Kevin Sweeney
• Reporter: Kevin Sweeney
• Created: 16/Mar/15 18:28
• Updated: 16/Mar/15 22:27
• Resolved: 16/Mar/15 22:27

Description

The recent patch to enable HTTP Basic Authentication moved construction of ThriftAuthModule to the Jetty child injector, but the user-supplied module was still installed in the parent injector. This leads to a stack trace for anyone using their own auth_module:

INFO: Connecting to master using authentication (principal: TwitterScheduler).
Exception in thread "main" com.google.inject.CreationException: Guice creation errors:

1) No implementation for java.util.Map<org.apache.aurora.auth.CapabilityValidator$Capability, java.lang.String> was bound.
  while locating java.util.Map<org.apache.aurora.auth.CapabilityValidator$Capability, java.lang.String>
    for parameter 1 at com.twitter.aurora.internal.auth.TwitterCapabilityValidator.<init>(TwitterCapabilityValidator.java:28)
  at com.twitter.aurora.internal.auth.TwitterAuthModule.configure(TwitterAuthModule.java:97)

2) No implementation for java.util.Map<org.apache.aurora.auth.CapabilityValidator$Capability, java.lang.String> was bound.
  at com.twitter.aurora.internal.auth.TwitterAuthModule.configure(TwitterAuthModule.java:94)

2 errors
        at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:435)
        at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:154)
        at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:106)
        at com.google.inject.Guice.createInjector(Guice.java:95)
        at com.google.inject.Guice.createInjector(Guice.java:83)
        at com.twitter.common.application.AppLauncher.configureInjection(AppLauncher.java:120)
        at com.twitter.common.application.AppLauncher.run(AppLauncher.java:87)
        at com.twitter.common.application.AppLauncher.launch(AppLauncher.java:181)
        at com.twitter.common.application.AppLauncher.launch(AppLauncher.java:142)
        at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:279)

Issue Links

• blocks: AURORA-904 0.8.0 Release Candidate