[ARTEMIS-996] Simplify and deduplicate lookupHome(path) in artemis-maven-plugin

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Broker
• Flags: Patch
• External issue URL: https://scan7.coverity.com/reports.htm#v25199/p14213/fileInstanceId=9928506&defectInstanceId=2438134&mergedDefectId=1409558
• External issue ID: 1409558, 1409557
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 24/Feb/17 15:44
• Updated: 31/Aug/17 19:11
• Resolved: 24/Feb/17 16:11

Description

ArtemisCLIPlugin.java and ArtemisCreatePlugin.java in artemis-maven-plugin both contain the following code

 85      Path binFolder = path.resolve("bin");
 86
 87      if (binFolder == null && Files.exists(binFolder, LinkOption.NOFOLLOW_LINKS)) {
 88         return false;
 89      }

Check for null is unnecessary, because Path#resolve never returns null, and also the condition in if does not make any sense.

Issue Links

• links to: GitHub Pull Request #1045