[ARTEMIS-993] ClientConsumerImpl.java contains unreachable code

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Broker
• External issue URL: https://scan7.coverity.com/reports.htm#v25199/p14213/fileInstanceId=9926975&defectInstanceId=2438084&mergedDefectId=1409700
• External issue ID: 1409700
• Assignee: Justin Bertram
• Reporter: Jiri Daněk
• Created: 24/Feb/17 10:05
• Updated: 31/Aug/17 19:11
• Resolved: 10/Mar/17 13:43

Description

ClientConsumerImpl.java contains code similar to this abbreviated snippet

236            ClientMessageInternal m = null;
...
239               while ((stopped || (m = buffer.poll()) == null) && !closed && toWait > 0) {
...
256                  if (m != null) {
257                     session.workDone();
258                  }
...

According to static analysis (and I concur), It is logically impossible for m != null to be true inside the body of the while loop.

I am not aware of this having any observable effect in terms of incorrect behavior, so I am assigning the lowest priority.

See the actual code at https://github.com/apache/activemq-artemis/blob/f698a7f8189af7b70160ba18596be371642776bb/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java#L239

Issue Links

• links to: GitHub Pull Request #1047