[ARTEMIS-826] MQTT with a long password field causes NPE exception

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.4.0, 1.5.0
• Fix Version/s: 2.1.0
• Labels: mqtt
• Assignee: Martyn Taylor
• Reporter: luca capra
• Created: 26/Oct/16 13:44
• Updated: 08/May/17 18:20
• Resolved: 08/May/17 18:20

Description

Hi
I'm using mqtt.js and Paho (java) as client for MQTT protocol.
The issue can be replicated both on (my embed) version pointing at master (1.5.0-SNAPSHOT) and with a clean install of 1.4.0 release

Happens by using a long password (a jwt token in my case) which causes this exception on both versions

Example password:
eyJhbGciOiJIUzUxMiJ9.eyJjcmVhdGVkIjoxNDc3NDg1NDc5OTEzLCJleHAiOjE0Nzc0ODcyNzksInV1aWQiOiI2NmVkNDc3Mi0wNDg5LTRlOTYtYmI2NS01NDhiMmVkMmM3MWQifQ.LbOAr8pPApDlVBLi32JWtCjmCa80ByAJYq9BnTnWQgh4SWka4WzykMU0D_atE5tYtgICj2QOg-OFglv2ZqLLNw

Exception:
Caused by: java.lang.NullPointerException
at org.apache.activemq.artemis.core.protocol.ProtocolHandler$ProtocolDecoder.decode(ProtocolHandler.java:185) [artemis-server-1.4.0.jar:1.4.0]

Looking at the source Artemis receive a different set of bytes ("M"QTT starts at array[5])

https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java#L131

—

MQTT spec on password length (0 to 65535 bytes of binary data + 2bytes for length)

http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc385349246

Client code is here:
https://gist.github.com/muka/df7cac712a645b9f1895274adcbe3670

Embed artemis code is here:
https://github.com/muka/raptor/tree/master/raptor-broker

Thanks!

Issue Links

• is related to: AMQ-6661 Auto transport with MQTT will fail for a long password
• links to: GitHub Pull Request #1227