[ARTEMIS-501] Incorrect log message in class ClientSessionFactoryImpl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.3.0
• Component/s: AMQP
• Assignee: Unassigned
• Reporter: Chen Maoqian
• Created: 25/Apr/16 02:14
• Updated: 03/Nov/16 20:39
• Resolved: 25/Apr/16 17:30

Description

There is incorrect logging message present in method establishNewConnection() in class org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl .

protected RemotingConnection establishNewConnection() {
....
RemotingConnection newConnection = clientProtocolManager.connect(...);
newConnection.addFailureListener(new DelegatingFailureListener(newConnection.getID()));
schedulePing();
if (ActiveMQClientLogger.LOGGER.isTraceEnabled())

{ ActiveMQClientLogger.LOGGER.trace("returning " + connection); }

return newConnection;
}

Log message says, that it is returning connection (old one, present as an attribute of class), but connection stored in newConnection variable is returned (and then it is set as this.connection).