[ARTEMIS-4915] TotalMessagesAdded/Acknowledged descriptions are misleading

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.38.0
• Component/s: JMX, management
• Assignee: Justin Bertram
• Reporter: Josh Byster
• Created: 10/Jul/24 04:35
• Updated: 16/Oct/24 16:02
• Resolved: 03/Sep/24 11:13

Description

Currently, the total messages added/acknowledged fields are computed by summing up the counts on the individual queues, i.e.

   @Override
   public long getTotalMessagesAdded() {
      long total = 0;

      for (Binding binding : iterableOf(postOffice.getAllBindings())) {
         if (binding.getType() == BindingType.LOCAL_QUEUE) {
            total += ((LocalQueueBinding) binding).getQueue().getMessagesAdded();
         }
      }

      return total;
   }

This fails to give an accurate count if queues are being created or deleted (for example, as consumers disconnect or reconnect).
This can easily be demonstrated by sending messages and then disconnecting all consumers (with queue auto-deletion) and seeing the "messages added" count drop to 0.

Issue Links

• links to: GitHub Pull Request #5182