[ARTEMIS-4805] Null dereferencing in ScaleDownHandler.java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.38.0
• Assignee: Justin Bertram
• Reporter: Galkin Alexey
• Created: 07/Jun/24 09:30
• Updated: 16/Oct/24 16:02
• Resolved: 05/Sep/24 18:29

Description

In line 333 in file ScaleDownHandler.java variable queueCreateSession is initialized

ClientSession queueCreateSession = sessionFactory.createSession(user, password, false, true, true, false, 0);

In  line 851 in ClientSessionFactoryImp.java, the code synchronizes with the sessions collection and checks whether the current session is closed or whether the client protocol manager is down. If the closed session or inactive client protocol manager condition is met, the session is closed and null is returned

if (closed || !clientProtocolManager.isAlive()) {
   session.close();
   return null;
}

The queueCreateSession variable could potentially be null.

In line 357 in file ScaleDownHandler.java variable queueCreateSession is passed to the function createQueueWithRoutingTypeIfNecessaryAndGetID as the first argument:

queueID = createQueueWithRoutingTypeIfNecessaryAndGetID(queueCreateSession, queue, message.getAddressSimpleString(), message.getRoutingType());

In line 450 in file ScaleDownHandler.java potential null dereference occurs:

session.createQueue(new QueueConfiguration(...));