[ARTEMIS-4710] Keep pem-keystore dependencies as is; make it really optional

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.33.0
• Fix Version/s: 2.34.0
• Assignee: Unassigned
• Reporter: Alexey Markevich
• Created: 02/Apr/24 12:22
• Updated: 29/May/24 15:15
• Resolved: 02/Apr/24 16:59

Description

Previously we excluded bcprov-jdk15on and bcpkix-jdk15on dependencies normally used by pem-keystore, and replaced them with bcprov-jdk18on and bcpkix-jdk18on as already managed and used elsewhere in the build, thus keeping things consistent on a single gav for the bc modules.

The latest 2.3.0 version of pem-keystore (used since ARTEMIS-4599) was actually changed to use bcprov-jdk18on and bcpkix-jdk18on in https://github.com/ctron/pem-keystore/commit/1263b207da0adf4a7d2dc61d6a9a19e7bba97731. As such we can now simplify the dependency handling by removing the prior exclusion+replacement handling for those deps.

Additionally, by avoiding a global import on PemKeyStoreProvider, and only referencing it upon use, those who wish would be able to exclude the dependency when the functionality is not used.

Issue Links

• supercedes: ARTEMIS-4528 TLS support PEM format for key and trust store type
• links to: GitHub Pull Request #4870