Uploaded image for project: 'ActiveMQ Artemis'
  1. ActiveMQ Artemis
  2. ARTEMIS-4509

ActiveMQTestBase leak check should identify state clearly without need of logs

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.31.2
    • 2.32.0
    • None
    • None

    Description

      The ActiveMQTestBase class does some leak checking on the LibaioContext resource usage during the test suite. There is a pre-class check that logs when it first detects a leak happened before the (typically in a non-ActiveMQTestBase test class), or fails immediately if a previous class has detected the leak and failed (after), and a post-class check that fails if things dont hit 0-usage within 30 seconds.

      This is fine for local usage but is a bit of a pain for cases where the pre-class foul happens in a CI env, as it isnt always so easy to find, get, and examine the full specific class logs to determine the precise status of when the issue occurred. It would be more useful if the pre-class foul detection actually just failed immediately (as will already happen after) and created an error that explicitly identifies the status from the test fail without needing to examine the logs at all.

      Attachments

        Activity

          People

            robbie Robbie Gemmell
            robbie Robbie Gemmell
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: