[ARTEMIS-4477] artemis-commons does not transform the META-INF/services/javax.json.spi.JsonProvider to the shaded package

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.31.1
• Fix Version/s: 2.31.2
• Component/s: Broker
• Assignee: Robbie Gemmell
• Reporter: George Gastaldi
• Created: 26/Oct/23 20:05
• Updated: 27/Oct/23 15:52
• Resolved: 27/Oct/23 10:20

Description

Johnzon is shaded in artemis-common but the META-INF/services/javax.json.spi.JsonProvider included in the artemis-commons JAR points to the original class, not the shaded one, causing the following error when used as a dependency:

Caused by: java.util.ServiceConfigurationError: javax.json.spi.JsonProvider: Provider org.apache.johnzon.core.JsonProviderImpl not found
    at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:589)
    at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1212)
    at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
    at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
    at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
    at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
    at javax.json.spi.JsonProvider.provider(JsonProvider.java:68)
    at io.smallrye.health.SmallRyeHealthReporter.<init>(SmallRyeHealthReporter.java:126)
    at io.smallrye.health.SmallRyeHealthReporter_ClientProxy.<init>(Unknown Source)
    at io.smallrye.health.SmallRyeHealthReporter_Bean.proxy(Unknown Source)
    at io.smallrye.health.SmallRyeHealthReporter_Bean.get(Unknown Source)
    at io.smallrye.health.SmallRyeHealthReporter_Bean.get(Unknown Source)
    at io.quarkus.arc.impl.InstanceImpl.getBeanInstance(InstanceImpl.java:229)
    at io.quarkus.arc.impl.InstanceImpl.getInternal(InstanceImpl.java:215)
    at io.quarkus.arc.impl.InstanceImpl.get(InstanceImpl.java:100)
    at io.quarkus.smallrye.health.runtime.SmallRyeHealthRecorder.processSmallRyeHealthRuntimeConfiguration(SmallRyeHealthRecorder.java:47)
    at io.quarkus.deployment.steps.SmallRyeHealthProcessor$processSmallRyeHealthRuntimeConfig1687788508.deploy_0(Unknown Source)
    at io.quarkus.deployment.steps.SmallRyeHealthProcessor$processSmallRyeHealthRuntimeConfig1687788508.deploy(Unknown Source)
    ... 53 more
 

This bug seems to have been introduced in 
https://github.com/apache/activemq-artemis/commit/3392d084a904f9517a30242facb0159cf94fbc87

Issue Links

• is caused by: ARTEMIS-4435 Some Artemis artifacts misses MANIFEST.MF content
• links to: GitHub Pull Request #4657
• links to: GitHub Pull Request #4658