[ARTEMIS-4291] Some metrics do not have the "broker" tag

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.28.0
• Fix Version/s: 2.29.0
• Component/s: Broker
• Assignee: Unassigned
• Reporter: Roelof Naude
• Created: 24/May/23 14:44
• Updated: 21/Jun/23 14:16
• Resolved: 21/Jun/23 14:16

Description

Some metrics do not have the "broker" tag. The "broker" may not match the "instance" added by e.g. prometheus, leading to a mismatch.

MetricsManager should ideally add "broker" to the common tags, e.g:

meterRegistry.config().commonTags("broker", brokerName);

 

PR 4487 was submitted to resolve this.

Issue Links

• links to: GitHub Pull Request #4487