[ARTEMIS-4003] FlowControl on BridgeImpl is broken for Large Messages

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.26.0
• Assignee: Clebert Suconic
• Reporter: Clebert Suconic
• Created: 19/Sep/22 13:43
• Updated: 05/Oct/22 08:54
• Resolved: 05/Oct/22 08:54

Description

LargeMessages over BridgeImpl (including Clustering) will request more credits eventually than what they are entitled. This is because we don't flow control the large message producer on the Bridge (at least not yet), and the sender could get to a window where it requested more credits than it was entitled. The flow control on the Bridge is limited to handle returning busy or not (and that should be enough really).

as a Result, the flow control will never refill and the bridge would freeze and get stuck.

To fix this situation we should check for the starve at the end of the receive credits and do the proper refill.

I am writing a test validating this issue, it will be under smokeTests and it will be named org.apache.activemq.artemis.tests.smoke.clusteredLargeMessage.ClusteredLargeMessageTest

Issue Links

• links to: GitHub Pull Request #4224