[ARTEMIS-391] Connection Limit doesn't log when over the limit

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.3.0
• Assignee: Justin Bertram
• Reporter: Clebert Suconic
• Created: 05/Feb/16 20:49
• Updated: 03/Nov/16 20:40
• Resolved: 18/Feb/16 16:29

Description

The current security limit doesn't log anything when going beyond the limit:

there is a Log.DEBUG, and an empty exception that is not shown anywhere.

else {
if (ActiveMQServerLogger.LOGGER.isDebugEnabled())

{ ActiveMQServerLogger.LOGGER.debug(new StringBuilder().append("Connection limit of ").append(connectionsAllowed).append(" reached. Refusing connection from ").append(ctx.channel().remoteAddress())); }

throw new Exception();
}

The conneciton should be closed, and proper log should be printed. I think this is a situation for log.warn as the admins will need to be aware of it.