[ARTEMIS-3909] Move RoutingContext::processReferences to PostOfficeImpl

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.25.0
• Assignee: Clebert Suconic
• Reporter: Clebert Suconic
• Created: 28/Jul/22 16:12
• Updated: 28/Jul/22 17:38
• Resolved: 28/Jul/22 17:38

Description

Reasoning:

• We reuse the Routing Context as an optimization on the ServerSession.
• By the time the Routing is done, we will process the references on a IO callback.
• if anyone used any state in between the Routing and Storage, you could have an invalid operation.

We were lucky that the method processReferences in PostOffice was pretty much static and no actual bug happened because of that, however I almost thought we had something scary going on.

So, to avoid this kind of issue ever being introduced in the codebase I am moving the processReferences away from RoutingContext.

Issue Links

• links to: GitHub Pull Request #4156