[ARTEMIS-3475] Possible recursion on PacketImpl::toString

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.19.0
• Assignee: Unassigned
• Reporter: Clebert Suconic
• Created: 13/Sep/21 16:04
• Updated: 17/Sep/21 14:48
• Resolved: 14/Sep/21 16:47

Description

This is a mix of a bug and a task...

classes extending Packet on core client are using a method named getParentString() on the toString();

The initial intent was to be simple and never to abuse inheritance on the getParentString();

Recent iteration on the code added a few occasions with toString() calling getParentString() calling toString() what caused a recursive loop.

I'm making this simpler. by introducing a getPacketString() on PacketImpl where every extension of PacketImpl to simply call super.getParentString();

Even though it still possible for someone to call itself on getParentString(), at least it would be clearer and easier to catch on revisions.

Issue Links

• links to: GitHub Pull Request #3744