[ARTEMIS-3459] AMQPMessage.scanMessageData() creates unecessary buffer wrapper

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.18.0
• Fix Version/s: 2.19.0
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 03/Sep/21 16:17
• Updated: 03/Sep/21 17:07
• Resolved: 03/Sep/21 17:07

Description

The AMQPMessage.scanMessageData(ReadableBuffer) method creates an unecessary buffer wrapper on every decode. The method has the equivalent of:

decoder.setBuffer(data);
 try {
   //...use decoder..
 } finally {
   decoder.setByteBuffer(null);
 }

Effectively it tries to use the thread-local decoder, then ensure the related buffer is discarded after.

However the two setter uses are different, with the former taking the ReadableBuffer directly, and the latter method expected to be passed a ByteBuffer, which causes creation of a ReadableBuffer wrapper for it. By passing it null with that method, a needless wrapper object is created. One which is discarded on the next decode by that thread when it sets the next actual buffer. It should be using setBuffer(null).