[ARTEMIS-3241] binary archive LICENSE file contains improper (and possibly stale) entries for management console deps

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.17.0
• Fix Version/s: 2.18.0
• Component/s: Web Console
• Assignee: Domenico Francesco Bruscino
• Reporter: Robbie Gemmell
• Created: 13/Apr/21 17:36
• Updated: 09/Aug/21 17:57
• Resolved: 16/Jun/21 15:37

Description

The licence file shipped with the binary distribution contains a lot of improper, and possibly stale (see later), entries relating to the management console deps:
https://github.com/apache/activemq-artemis/blob/2.17.0/artemis-distribution/src/main/resources/licenses/bin/LICENSE#L256-L435

These entries added mostly link to a file in an external repository, on its master branch. This applicable licences should actually be in the distribution itself (either directly in LICENCE, or in another file referenced from it), links arent sufficient because their contents can change over time (e.g licence and/or version changes) or even go away entirely or just be broken (e.g branch changes) and so may not actually reflect the needed detail or the state that existed when the dependency was used and the LICENCE file entry added.

Further, these entries could also be somewhat stale now, because they were added in ARTEMIS-1270 back in 2017 but the console has been overhauled recently in ARTEMIS-2838. In addition to being updated to actually ship the licence, the entries should be verified as still applying, and that there aren't any new ones needed from the console update.

(Noticed during discussion of LICENSE changes on https://github.com/apache/activemq-artemis/pull/3527 / ARTEMIS-3221)

Issue Links

• relates to: ARTEMIS-1270 Provide a Management Console for Artemis
• relates to: ARTEMIS-2838 Migrate Console to use Hawtio 2
• links to: GitHub Pull Request #3546
• links to: GitHub Pull Request #3574