[ARTEMIS-2955] commons-dbcp2 performance issue with Derby Embedded DBMS

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.16.0
• Fix Version/s: 2.16.0
• Component/s: Broker, Tests
• Assignee: Francesco Nigro
• Reporter: Francesco Nigro
• Created: 20/Oct/20 07:16
• Updated: 03/Nov/20 01:17
• Resolved: 20/Oct/20 12:47

Description

The test suite has shown an increase in duration of 30 minutes going from to 2:30 to 3 hours: it seems related to integration paging tests running on Embedded Derby with the changes of ARTEMIS-2823.

After some profiling sessions on org/apache/activemq/artemis/tests/integration/paging/PagingTest.testQueueRemoveAll it seems that using commons-dbcp2 with Embedded Derby isn't working as expected:

while, if we switch to EmbeddedDataSource we have

By not using commons-dbcp2 we get roughtly a ~10X improvement in performance: it seems that commons-dbcp2 is forcing to setup from the ground the prepared statement each time, while EmbeddedDataSource nope. Specifically it seems related to Derby GenericActivationHolder.
I suggest to disable commons-dbcp2 for Derby and investigate if it could happen in a real broker too.

 

Issue Links

• is caused by: ARTEMIS-2823 Improve JDBC connection management
• links to: GitHub Pull Request #3308