[ARTEMIS-2769] NumberFormatException

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.12.0, 2.13.0
• Fix Version/s: 2.14.0
• Labels: easyfix
• Assignee: Clebert Suconic
• Reporter: Todor Neykov
• Created: 19/May/20 12:16
• Updated: 09/Jul/20 23:24
• Resolved: 11/Jun/20 14:22

Description

Hi,
I found an issue in ConfigurationHelper.getIntProperty() 
If there is a String propery but not a numeric value it lead to NumberFormatException. 
My expectation in this case is to be returned a default value instead of exception. 

The code is

if (prop instanceof String) {
    return Integer.valueOf((String) prop);
} else ...
 

Fix proposal : 

if (prop instanceof String)
{
    try
    {
        return Integer.valueOf((String)prop);
    }
    catch (NumberFormatException e)
    {
        ActiveMQClientLogger.LOGGER.propertyNotInteger(propName, prop.getClass().getName());
        return def;
    }
}
else ...

Same case is in getLongProperty()