[ARTEMIS-2743] Synchronize JMS connection methods

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.13.0
• Assignee: Justin Bertram
• Reporter: Justin Bertram
• Created: 29/Apr/20 18:44
• Updated: 29/Apr/20 23:30
• Resolved: 29/Apr/20 23:30

Description

org.apache.activemq.artemis.jms.client.ActiveMQConnection#createSession(boolean, int) and org.apache.activemq.artemis.jms.client.ActiveMQConnection#close have always used synchronized. However, many of the other variants of createSession don't use synchronized which can lead to concurrency issues, specifically a NullPointerException when concurrently closing a connection and creating a session from that connection.