[ARTEMIS-2697] Avoid using raw types for Persister<T>

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.11.0
• Assignee: Unassigned
• Reporter: Francesco Nigro
• Created: 06/Apr/20 07:30
• Updated: 07/Sep/21 07:47

Description

Persister<T> has been introduced by ARTEMIS-1009 Pure Message Encoding, but during the refactoring process some bits are being left around to properly use Java Generics to help spotting wrong assignments at compile time eg

public interface Journal extends ActiveMQComponent {

   // ...

   void appendAddRecord(long id,
                        byte recordType,
                        Persister persister,
                        Object record,
                        boolean sync,
                        IOCompletion completionCallback) throws Exception;

And by consequence, a caller on AbstractJournalStorageManager:

if (message.isLargeMessage() && message instanceof LargeServerMessageImpl) {
            messageJournal.appendAddRecord(message.getMessageID(), JournalRecordIds.ADD_LARGE_MESSAGE, LargeMessagePersister.getInstance(), message, false, getContext(false));

Where LargeMessagePersister.getInstance() is a Persister<LargeServerMessage> and message is a Message and such method call should not compile at all (but it does)

Issue Links

• is caused by: ARTEMIS-1009 Pure Encoding of Messages
• links to: GitHub Pull Request #3053