[ARTEMIS-2429] Swapped arguments to registerQueueGauge cause wrong tags on metrics

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.0
• Fix Version/s: 2.10.0
• Component/s: Broker
• Flags: Patch
• External issue URL: https://scan.coverity.com/projects/apacheactivemqartemis
• External issue ID: CID 1483198
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 22/Jul/19 11:24
• Updated: 26/Aug/19 15:49
• Resolved: 26/Aug/19 15:49

Description

*** CID 1483198:  API usage errors  (SWAPPED_ARGUMENTS)
/activemq-artemis/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java: 3872 in org.apache.activemq.artemis.core.server.impl.QueueImpl.registerMeters()()
3866           String addressName = address.toString();
3867           String queueName = name.toString();
3868     
3869           if (server != null && server.getMetricsManager() != null) {
3870              MetricsManager metricsManager = server.getMetricsManager();
3871     
>>>     CID 1483198:  API usage errors  (SWAPPED_ARGUMENTS)
>>>     The positions of arguments in the call to "registerQueueGauge" do not match the ordering of the parameters:
* "queueName" is passed to "address"
* "addressName" is passed to "queue"
3872              metricsManager.registerQueueGauge(queueName, addressName, (builder) -> {
3873                 builder.register(QueueMetricNames.MESSAGE_COUNT, pendingMetrics, metrics -> Double.valueOf(pendingMetrics.getMessageCount()), QueueControl.MESSAGE_COUNT_DESCRIPTION);
3874                 builder.register(QueueMetricNames.DURABLE_MESSAGE_COUNT, pendingMetrics, metrics -> Double.valueOf(pendingMetrics.getDurableMessageCount()), QueueControl.DURABLE_MESSAGE_COUNT_DESCRIPTION);
3875                 builder.register(QueueMetricNames.PERSISTENT_SIZE, pendingMetrics, metrics -> Double.valueOf(pendingMetrics.getPersistentSize()), QueueControl.PERSISTENT_SIZE_DESCRIPTION);
3876                 builder.register(QueueMetricNames.DURABLE_PERSISTENT_SIZE, pendingMetrics, metrics -> Double.valueOf(pendingMetrics.getDurablePersistentSize()), QueueControl.DURABLE_PERSISTENT_SIZE_DESCRIPTION);
3877     

Issue Links

• links to: GitHub Pull Request #2763