[ARTEMIS-236] Improve Legacy support on older migrating clients

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.2.0
• Assignee: Clebert Suconic
• Reporter: Howard Nguyen
• Created: 29/Sep/15 21:29
• Updated: 03/Nov/16 20:40
• Resolved: 08/Jun/16 13:17

Description

On connect,

Client repeatedly log (ip is removed)

2015-09-29 17:20:35,750 WARN  [org.hornetq.core.protocol.core.impl.RemotingConnectionImpl] (Thread-36 (HornetQ-client-global-threads-1087057800)) Connection failure has been detected: Did not receive data from server for org.hornetq.core.remoting.impl.netty.NettyConnection@2a864afa[local= /x.x.x.x:53907, remote=/y.y.y.y:5445] [code=3]

Server repeatedly log

17:12:07,012 WARNING [io.netty.channel.DefaultChannelPipeline] An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.: io.netty.handler.codec.DecoderException: java.lang.NullPointerException
        at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:358) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:230) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at org.apache.activemq.artemis.core.protocol.ProtocolHandler$ProtocolDecoder.channelRead(ProtocolHandler.java:117) [artemis-server-1.1.0.jar:1.1.0]
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:308) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:294) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:110) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        at java.lang.Thread.run(Thread.java:745) [rt.jar:1.8.0_60]
Caused by: java.lang.NullPointerException
        at org.apache.activemq.artemis.core.protocol.ProtocolHandler$ProtocolDecoder.decode(ProtocolHandler.java:162) [artemis-server-1.1.0.jar:1.1.0]
        at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:327) [netty-all-4.0.30.Final.jar:4.0.30.Final]
        ... 12 more

broker.xml

                        <connector name="hornetq">tcp://0.0.0.0:5445?protocols=HORNETQ,STOMP</connector>

Single client using hornetq 2.2.16.FINAL, and single artemis 1.1.0

Issue Links

• is related to: ARTEMIS-238 Expand legacy support to clients and improve existing ClientProtocolManager