[ARTEMIS-2342] The reload logging configuration at runtime for Active MQ Servers may log warnings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.4, 2.7.0, 2.8.0, 2.8.1
• Fix Version/s: 2.9.0
• Component/s: AMQP
• Assignee: Unassigned
• Reporter: James R. Perkins
• Created: 16/May/19 15:56
• Updated: 30/May/19 18:25
• Resolved: 30/May/19 18:25

Description

The issue JBEAP-16896 has some details about the issue. The stack trace logged as a warning is:

 
2019-05-13 11:45:11,419 WARN  [org.apache.activemq.artemis.core.server] (ServerService Thread Pool -- 78) AMQ222277: Problem initializing automatic logging configuration reload for file:C:\Java\jboss\jboss-as\standalone\configuration/logging.properties: java.net.URISyntaxException: Illegal character in opaque part at index 7: file:C:\Java\jboss\jboss-as\standalone\configuration/logging.properties
	at java.net.URI$Parser.fail(URI.java:2848)
	at java.net.URI$Parser.checkChars(URI.java:3021)
	at java.net.URI$Parser.parse(URI.java:3058)
	at java.net.URI.<init>(URI.java:588)
	at org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2369)
	at org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:64)
	at org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:544)
	at org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:481)
	at org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:376)
	at org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:206)
	at org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:65)
	at org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:100)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1349)
	at java.lang.Thread.run(Thread.java:748)
	at org.jboss.threads.JBossThread.run(JBossThread.java:485)

 
This also means the server will not reload the logging configuration as it fails. The reason being in this case is because the logging.configuration is stored as a URL not a URI and the line in ActiveMQServerImpl uses new URI(System.getProperty("logging.configuration")).toURL() and it should just be using new URL(System.getProperty("logging.configuration")).

Issue Links

• is caused by: ARTEMIS-2121 Reload logging configuration at runtime
• links to: GitHub Pull Request #2672