Uploaded image for project: 'ActiveMQ Artemis'
  1. ActiveMQ Artemis
  2. ARTEMIS-2323

NettyTransport should also send requests with void promises

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.1
    • Component/s: AMQP, STOMP
    • Labels:
      None

      Description

      AmqpConnection is using NettyTransport::send without making use of ChannelFuture
      return type, but NettyTcpTransport/NettyWSTransport always allocate a new ChannelPromise
      on each call.
      If such ChannelFuture isn't needed (like STOMP does) it would be better to avoid the ChannelPromise instantiation and enhance the API with a proper method.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jbertram Justin Bertram
                Reporter:
                nigro.fra@gmail.com Francesco Nigro
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 10m
                  2h 10m