Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.6.3
    • 2.6.4
    • Broker
    • None

    Description

      When a receiving transaction is committed in a paging situation,
      if a page happens to be completed and it will be deleted in a
      transaction operation (PageCursorTx). The other tx operation
      RefsOperation needs to access the page (in PageCache) to finish
      its job. There is a chance that the PageCursorTx removes the
      page before RefsOperation and it will cause the RefsOperation
      failed to find a message in a page.

       

      Attachments

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user gaohoward opened a pull request:

          https://github.com/apache/activemq-artemis/pull/2455

          ARTEMIS-2197 Page deleted before transaction finishes

          When a receiving transaction is committed in a paging situation,
          if a page happens to be completed and it will be deleted in a
          transaction operation (PageCursorTx). The other tx operation
          RefsOperation needs to access the page (in PageCache) to finish
          its job. There is a chance that the PageCursorTx removes the
          page before RefsOperation and it will cause the RefsOperation
          failed to find a message in a page.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/gaohoward/activemq-artemis a_e2011_2

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/2455.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2455


          commit 3ebd2e49e5945f305dc68e1be83218bbde3c7085
          Author: Howard Gao <howard.gao@...>
          Date: 2018-12-10T03:19:15Z

          ARTEMIS-2197 Page deleted before transaction finishes

          When a receiving transaction is committed in a paging situation,
          if a page happens to be completed and it will be deleted in a
          transaction operation (PageCursorTx). The other tx operation
          RefsOperation needs to access the page (in PageCache) to finish
          its job. There is a chance that the PageCursorTx removes the
          page before RefsOperation and it will cause the RefsOperation
          failed to find a message in a page.


          githubbot ASF GitHub Bot added a comment - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2455 ARTEMIS-2197 Page deleted before transaction finishes When a receiving transaction is committed in a paging situation, if a page happens to be completed and it will be deleted in a transaction operation (PageCursorTx). The other tx operation RefsOperation needs to access the page (in PageCache) to finish its job. There is a chance that the PageCursorTx removes the page before RefsOperation and it will cause the RefsOperation failed to find a message in a page. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis a_e2011_2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2455.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2455 commit 3ebd2e49e5945f305dc68e1be83218bbde3c7085 Author: Howard Gao <howard.gao@...> Date: 2018-12-10T03:19:15Z ARTEMIS-2197 Page deleted before transaction finishes When a receiving transaction is committed in a paging situation, if a page happens to be completed and it will be deleted in a transaction operation (PageCursorTx). The other tx operation RefsOperation needs to access the page (in PageCache) to finish its job. There is a chance that the PageCursorTx removes the page before RefsOperation and it will cause the RefsOperation failed to find a message in a page.
          githubbot ASF GitHub Bot added a comment -

          Github user gaohoward commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2455

          @clebertsuconic Can you review this? thx.

          githubbot ASF GitHub Bot added a comment - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2455 @clebertsuconic Can you review this? thx.

          Commit b36dc37c152cabe3a0d9af178db043f842bfcdc0 in activemq-artemis's branch refs/heads/master from Howard Gao
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b36dc37 ]

          ARTEMIS-2197 Page deleted before transaction finishes

          When a receiving transaction is committed in a paging situation,
          if a page happens to be completed and it will be deleted in a
          transaction operation (PageCursorTx). The other tx operation
          RefsOperation needs to access the page (in PageCache) to finish
          its job. There is a chance that the PageCursorTx removes the
          page before RefsOperation and it will cause the RefsOperation
          failed to find a message in a page.

          jira-bot ASF subversion and git services added a comment - Commit b36dc37c152cabe3a0d9af178db043f842bfcdc0 in activemq-artemis's branch refs/heads/master from Howard Gao [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b36dc37 ] ARTEMIS-2197 Page deleted before transaction finishes When a receiving transaction is committed in a paging situation, if a page happens to be completed and it will be deleted in a transaction operation (PageCursorTx). The other tx operation RefsOperation needs to access the page (in PageCache) to finish its job. There is a chance that the PageCursorTx removes the page before RefsOperation and it will cause the RefsOperation failed to find a message in a page.
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/2455

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2455
          githubbot ASF GitHub Bot added a comment -

          GitHub user gaohoward opened a pull request:

          https://github.com/apache/activemq-artemis/pull/2462

          ARTEMIS-2197 Page deleted before transaction finishes

          When a receiving transaction is committed in a paging situation,
          if a page happens to be completed and it will be deleted in a
          transaction operation (PageCursorTx). The other tx operation
          RefsOperation needs to access the page (in PageCache) to finish
          its job. There is a chance that the PageCursorTx removes the
          page before RefsOperation and it will cause the RefsOperation
          failed to find a message in a page.

          (cherry picked from b36dc37c152cabe3a0d9af178db043f842bfcdc0)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/gaohoward/activemq-artemis a_26x_2100

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/2462.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2462


          commit 44a0487f8fdb503a8b1ed849b1d0c2e039c133b8
          Author: Howard Gao <howard.gao@...>
          Date: 2018-12-10T05:35:04Z

          ARTEMIS-2197 Page deleted before transaction finishes

          When a receiving transaction is committed in a paging situation,
          if a page happens to be completed and it will be deleted in a
          transaction operation (PageCursorTx). The other tx operation
          RefsOperation needs to access the page (in PageCache) to finish
          its job. There is a chance that the PageCursorTx removes the
          page before RefsOperation and it will cause the RefsOperation
          failed to find a message in a page.

          (cherry picked from b36dc37c152cabe3a0d9af178db043f842bfcdc0)


          githubbot ASF GitHub Bot added a comment - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2462 ARTEMIS-2197 Page deleted before transaction finishes When a receiving transaction is committed in a paging situation, if a page happens to be completed and it will be deleted in a transaction operation (PageCursorTx). The other tx operation RefsOperation needs to access the page (in PageCache) to finish its job. There is a chance that the PageCursorTx removes the page before RefsOperation and it will cause the RefsOperation failed to find a message in a page. (cherry picked from b36dc37c152cabe3a0d9af178db043f842bfcdc0) You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis a_26x_2100 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2462.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2462 commit 44a0487f8fdb503a8b1ed849b1d0c2e039c133b8 Author: Howard Gao <howard.gao@...> Date: 2018-12-10T05:35:04Z ARTEMIS-2197 Page deleted before transaction finishes When a receiving transaction is committed in a paging situation, if a page happens to be completed and it will be deleted in a transaction operation (PageCursorTx). The other tx operation RefsOperation needs to access the page (in PageCache) to finish its job. There is a chance that the PageCursorTx removes the page before RefsOperation and it will cause the RefsOperation failed to find a message in a page. (cherry picked from b36dc37c152cabe3a0d9af178db043f842bfcdc0)
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2462

          There are tests broken on master.

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 There are tests broken on master.
          githubbot ASF GitHub Bot added a comment -

          GitHub user gaohoward opened a pull request:

          https://github.com/apache/activemq-artemis/pull/2463

          ARTEMIS-2197 Page deleted before transaction finishes

          Fixed regression caused by previous commit
          b36dc37c152cabe3a0d9af178db043f842bfcdc0

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/gaohoward/activemq-artemis a_e2011_regress

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/2463.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2463


          commit 2bd8fa7c5dcfb2c29a5c5f61ff433bf161b1b86e
          Author: Howard Gao <howard.gao@...>
          Date: 2018-12-13T12:17:14Z

          ARTEMIS-2197 Page deleted before transaction finishes

          Fixed regression caused by previous commit
          b36dc37c152cabe3a0d9af178db043f842bfcdc0


          githubbot ASF GitHub Bot added a comment - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2463 ARTEMIS-2197 Page deleted before transaction finishes Fixed regression caused by previous commit b36dc37c152cabe3a0d9af178db043f842bfcdc0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis a_e2011_regress Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2463 commit 2bd8fa7c5dcfb2c29a5c5f61ff433bf161b1b86e Author: Howard Gao <howard.gao@...> Date: 2018-12-13T12:17:14Z ARTEMIS-2197 Page deleted before transaction finishes Fixed regression caused by previous commit b36dc37c152cabe3a0d9af178db043f842bfcdc0
          githubbot ASF GitHub Bot added a comment -

          Github user gaohoward commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2463

          @clebertsuconic Can you take a look? thx.

          githubbot ASF GitHub Bot added a comment - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2463 @clebertsuconic Can you take a look? thx.

          Commit 2bd8fa7c5dcfb2c29a5c5f61ff433bf161b1b86e in activemq-artemis's branch refs/heads/master from Howard Gao
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=2bd8fa7 ]

          ARTEMIS-2197 Page deleted before transaction finishes

          Fixed regression caused by previous commit
          b36dc37c152cabe3a0d9af178db043f842bfcdc0

          jira-bot ASF subversion and git services added a comment - Commit 2bd8fa7c5dcfb2c29a5c5f61ff433bf161b1b86e in activemq-artemis's branch refs/heads/master from Howard Gao [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=2bd8fa7 ] ARTEMIS-2197 Page deleted before transaction finishes Fixed regression caused by previous commit b36dc37c152cabe3a0d9af178db043f842bfcdc0
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/2463

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2463
          githubbot ASF GitHub Bot added a comment -

          Github user gaohoward commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2462

          @clebertsuconic I've update the PR including the regression fix.

          githubbot ASF GitHub Bot added a comment - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 @clebertsuconic I've update the PR including the regression fix.
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2462

          I think you should keep separated commits.

          or if you squash, make it clear that this is a two commits squashed please?

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 I think you should keep separated commits. or if you squash, make it clear that this is a two commits squashed please?
          githubbot ASF GitHub Bot added a comment -

          Github user gaohoward commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2462

          ok, I'll make it separate commits. thx

          githubbot ASF GitHub Bot added a comment - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 ok, I'll make it separate commits. thx
          githubbot ASF GitHub Bot added a comment -

          Github user gaohoward commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2462

          @clebertsuconic It's done.

          githubbot ASF GitHub Bot added a comment - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 @clebertsuconic It's done.

          Commit b0a14ff3202f9aef6b29cb1f8764501469836d88 in activemq-artemis's branch refs/heads/2.6.x from Howard Gao
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b0a14ff ]

          ARTEMIS-2197 Page deleted before transaction finishes

          When a receiving transaction is committed in a paging situation,
          if a page happens to be completed and it will be deleted in a
          transaction operation (PageCursorTx). The other tx operation
          RefsOperation needs to access the page (in PageCache) to finish
          its job. There is a chance that the PageCursorTx removes the
          page before RefsOperation and it will cause the RefsOperation
          failed to find a message in a page.

          (cherry picked from b36dc37c152cabe3a0d9af178db043f842bfcdc0)

          jira-bot ASF subversion and git services added a comment - Commit b0a14ff3202f9aef6b29cb1f8764501469836d88 in activemq-artemis's branch refs/heads/2.6.x from Howard Gao [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b0a14ff ] ARTEMIS-2197 Page deleted before transaction finishes When a receiving transaction is committed in a paging situation, if a page happens to be completed and it will be deleted in a transaction operation (PageCursorTx). The other tx operation RefsOperation needs to access the page (in PageCache) to finish its job. There is a chance that the PageCursorTx removes the page before RefsOperation and it will cause the RefsOperation failed to find a message in a page. (cherry picked from b36dc37c152cabe3a0d9af178db043f842bfcdc0)

          Commit 8a2f65c781b481001d6638d3c6cc4e8b70451067 in activemq-artemis's branch refs/heads/2.6.x from Howard Gao
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8a2f65c ]

          ARTEMIS-2197 Page deleted before transaction finishes

          Fixed regression caused by previous commit
          b36dc37c152cabe3a0d9af178db043f842bfcdc0

          (cherry picked from 2bd8fa7c5dcfb2c29a5c5f61ff433bf161b1b86e)

          jira-bot ASF subversion and git services added a comment - Commit 8a2f65c781b481001d6638d3c6cc4e8b70451067 in activemq-artemis's branch refs/heads/2.6.x from Howard Gao [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8a2f65c ] ARTEMIS-2197 Page deleted before transaction finishes Fixed regression caused by previous commit b36dc37c152cabe3a0d9af178db043f842bfcdc0 (cherry picked from 2bd8fa7c5dcfb2c29a5c5f61ff433bf161b1b86e)
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on the issue:

          https://github.com/apache/activemq-artemis/pull/2462

          @gaohoward can you close this. It's merged after a rebase (I fixed a test failure you had here).

          Merge doesn't work well on 2.6.x.

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2462 @gaohoward can you close this. It's merged after a rebase (I fixed a test failure you had here). Merge doesn't work well on 2.6.x.
          githubbot ASF GitHub Bot added a comment -

          Github user gaohoward closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/2462

          githubbot ASF GitHub Bot added a comment - Github user gaohoward closed the pull request at: https://github.com/apache/activemq-artemis/pull/2462

          People

            gaohoward Howard Gao
            gaohoward Howard Gao
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment