[ARTEMIS-1955] Not all AMQP headers are mapped in AMQPCoreConverter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 2.6.2
• Component/s: AMQP
• Assignee: Unassigned
• Reporter: Simon Chalmers
• Created: 27/Jun/18 10:13
• Updated: 27/Jun/18 18:30
• Resolved: 27/Jun/18 18:30

Description

From here:

https://github.com/apache/activemq-artemis/blob/2c8b6b4aee7b03f2872f04f1d8caaa9d85436216/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java#L111-L177

It doesn't look like you're NOT mapping all the available AMQP headers to your internal message representation, specifically you're only doing 4 out of ~20

Your set:

populateMessage(result, message.getProtonMessage());
result.getInnerMessage().setReplyTo(message.getReplyTo());
result.getInnerMessage().setDurable(message.isDurable());
result.getInnerMessage().setPriority(message.getPriority());
result.getInnerMessage().setAddress(message.getAddressSimpleString());

The full header set for AMQP: http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format

So if someone were expecting their AMQP headers to be carried across, they would be lost.