[ARTEMIS-1950] Clarify STOMP durable subscription header names

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.7.0
• Assignee: Justin Bertram
• Reporter: Lionel Cons
• Created: 21/Jun/18 12:56
• Updated: 07/Aug/18 23:36
• Resolved: 07/Aug/18 23:36

Description

The STOMP documentation describes the use of durable-subscription-name and does not mention durable-subscriber-name at all.

However, the source code (VersionedStompFrameHandler.java) contains:

      String durableSubscriptionName = frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIBER_NAME);
      if (durableSubscriptionName == null) {
         durableSubscriptionName = frame.getHeader(Stomp.Headers.Subscribe.DURABLE_SUBSCRIPTION_NAME);
      }
      if (durableSubscriptionName == null) {
         durableSubscriptionName = frame.getHeader(Stomp.Headers.Subscribe.ACTIVEMQ_DURABLE_SUBSCRIPTION_NAME);
      }

In other words, if both durable-subscription-name and durable-subscriber-name are set, only the undocumented durable-subscriber-name is used.

Why do we have durable-subscriber-name in the first place?

If used, it should be documented. If not used, it should be removed.

BTW, activemq.subscriptionName is also used in the code and not documented. But at least it does not interfere with the documented durable-subscription-name as it comes after...

Issue Links

• links to: GitHub Pull Request #2158