[ARTEMIS-1634] Coverity: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) in QueueControlImpl.java

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.34.0
• Component/s: Broker
• External issue URL: https://scan7.coverity.com/reports.htm#v10043/p14213/fileInstanceId=46407726&defectInstanceId=9746876&mergedDefectId=1464349
• External issue ID: 9746876
• Assignee: Justin Bertram
• Reporter: Jiri Daněk
• Created: 24/Jan/18 16:44
• Updated: 11/Apr/24 03:43
• Resolved: 11/Apr/24 03:43

Description

   @Override
   public CompositeData[] browse(int page, int pageSize) throws Exception {
      String filter = null;
      checkStarted();

      clearIO();
      try {
         long index = 0;
CID 1464349 (#1 of 2): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) [select issue]
         long start = (page - 1) * pageSize;
CID 1464349 (#2 of 2): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)overflow_before_widen: Potentially
  overflowing expression page * pageSize with type int (32 bits, signed) is evaluated using 32-bit arithmetic, and then used
  in a context that expects an expression of type long (64 bits, signed). To avoid overflow, cast either page or pageSize to
  type long rather than casting the result of the potential overflow.
         long end = Math.min((long)(page * pageSize), queue.getMessageCount());

Issue Links

• is part of: ARTEMIS-1400 FindBugs warnings