[ARTEMIS-1538] trustAll is ignored when specified in the connectionFactory URI

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.5.0
• Flags: Patch
• Assignee: Christopher L. Shannon
• Reporter: Jiri Daněk
• Created: 05/Dec/17 17:04
• Updated: 03/May/18 18:49
• Resolved: 07/Dec/17 22:03

Description

When attempting to use the ARTEMIS-1469 feature trustAll option, I noticed that the client is ignoring this option. The reason seems to be that the option has not been added to the allowed list allowableConnectorKeys.

If I do the following change and rebuild active-jms-client jar, then I am able to use trustAll

index 5d86aaafa..d89cfb5ff 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java
@@ -355,6 +355,7 @@ public class TransportConstants {
       allowableConnectorKeys.add(TransportConstants.NETTY_CONNECT_TIMEOUT);
       allowableConnectorKeys.add(TransportConstants.USE_DEFAULT_SSL_CONTEXT_PROP_NAME);
       allowableConnectorKeys.add(TransportConstants.HANDSHAKE_TIMEOUT);
+      allowableConnectorKeys.add(TransportConstants.TRUST_ALL_PROP_NAME);
 
       ALLOWABLE_CONNECTOR_KEYS = Collections.unmodifiableSet(allowableConnectorKeys);

Issue Links

• relates to: ARTEMIS-1469 Support trusting any SSL client certificate for testing purposes
• links to: GitHub Pull Request #1694