[ARTEMIS-1475] NPE when deploying 2 MDBs with same clientID/subscriptionName

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.5
• Fix Version/s: 2.4.0
• Component/s: Broker
• Assignee: Unassigned
• Reporter: Jeff Mesnil
• Created: 23/Oct/17 11:48
• Updated: 03/Aug/21 13:33
• Resolved: 26/Feb/18 17:03

Description

Steps to reproduce:

• deploy an application in an app server using the Artemis Resource adapters with 2 MDBs that have the same clientID and subscriptionName activation config properties:

@MessageDriven(name = "HelloWorldQTopicMDB2", activationConfig = {
        @ActivationConfigProperty(propertyName = "destinationLookup", propertyValue = "topic/HELLOWORLDMDBTopic"),
        @ActivationConfigProperty(propertyName = "destinationType", propertyValue = "javax.jms.Topic"),
        @ActivationConfigProperty(propertyName = "subscriptionName", propertyValue = "mySubscription"),
        @ActivationConfigProperty(propertyName = "clientID", propertyValue = "myClientId"),
        @ActivationConfigProperty(propertyName = "subscriptionDurability", propertyValue = "Durable"),
        @ActivationConfigProperty(propertyName = "acknowledgeMode", propertyValue = "Auto-acknowledge")})

Result:

• when the application is deployed, it fails with the error:

  13:38:40,187 ERROR [org.apache.activemq.artemis.ra] (default-threads - 3) AMQ154003: Unable to reconnect org.apache.activemq.artemis.ra.inflow.ActiveMQActivatio
  nSpec(ra=org.wildfly.extension.messaging.activemq.ActiveMQResourceAdapter@2bd07716 destination=topic/HELLOWORLDMDBTopic destinationType=javax.jms.Topic ack=Auto
  -acknowledge durable=true clientID=myClientId subscription=mySubscription user=null maxSession=15): java.lang.NullPointerException
          at org.apache.activemq.artemis.ra.inflow.ActiveMQMessageHandler.setup(ActiveMQMessageHandler.java:125)
          at org.apache.activemq.artemis.ra.inflow.ActiveMQActivation.setup(ActiveMQActivation.java:314)
          at org.apache.activemq.artemis.ra.inflow.ActiveMQActivation.reconnect(ActiveMQActivation.java:658)
          at org.apache.activemq.artemis.ra.inflow.ActiveMQActivation$SetupActivation.run(ActiveMQActivation.java:698)
  

Expected outcome:

The deployment should fail with the correct exception from throw new javax.jms.IllegalStateException("Cannot create a subscriber on the durable subscription since it already has subscriber(s)");

The NPE is caused by ActiveMQActivationSpec#shareSubscriptions that is not instantiated to false in the default constructor.

In addition, the error message should be i18nized.

Issue Links

• links to: GitHub Pull Request #1603
• links to: GitHub Pull Request #1604