[ARTEMIS-1409] FindBugs: inefficient use of keySet iterator instead of entrySet iterator

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 2.4.0
• Component/s: Broker
• External issue URL: https://scan7.coverity.com/reports.htm#v14452/p14213/g14452g/fileInstanceId=34202217&defectInstanceId=7508529&mergedDefectId=1419417&eventId=7508529-0
• External issue ID: 1419417
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 11/Sep/17 17:09
• Updated: 23/Jan/18 16:51
• Resolved: 23/Jan/18 16:51

Description

Multiple occurrences of code like this

1391            for (String key : props.keySet()) {
1392               propstr.append(key);
1393               propstr.append("=");
    	
CID 1419417 (#1 of 1): WMI: Inefficient Map Iterator (FB.WMI_WRONG_MAP_ITERATOR)
1. defect: org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.listPreparedTransactionDetailsAsHTML() makes inefficient use of keySet iterator instead of entrySet iterator.
1394               propstr.append(props.get(key));
1395               propstr.append(", ");
1396            }

Issue Links

• incorporates: ARTEMIS-1400 FindBugs warnings