Uploaded image for project: 'ActiveMQ Artemis'
  1. ActiveMQ Artemis
  2. ARTEMIS-1294

TimedBuffer is not timing, reverting timeout policy

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.0
    • 2.2.0
    • Broker
    • None

    Description

      The timeout policy of TimedBuffer is reverted keeping the original timeout based, while retaining the other optimizations:

      • more memcpy under the hood vs single bytes copy
      • non-interruptible sleep (LockSupport.parkNanos)
      • off heap allocation

      Attachments

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user franz1981 opened a pull request:

          https://github.com/apache/activemq-artemis/pull/1403

          ARTEMIS-1294 Reverted TimedBuffer timeout policy

          The timeout policy of TimedBuffer is reverted keeping the original timeout based, while retaining the other optimizations:

          • more memcpy under the hood vs single bytes copy
          • non-interruptible sleep (LockSupport.parkNanos)
          • off heap allocation

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/franz1981/activemq-artemis timed_buffer_reverted

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/1403.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1403


          commit 9dbeadcbc96cf3e551be95c12ea1d1fb83823e6f
          Author: Francesco Nigro <nigro.fra@gmail.com>
          Date: 2017-07-17T15:35:38Z

          ARTEMIS-1294 Reverted TimedBuffer timeout policy


          githubbot ASF GitHub Bot added a comment - GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1403 ARTEMIS-1294 Reverted TimedBuffer timeout policy The timeout policy of TimedBuffer is reverted keeping the original timeout based, while retaining the other optimizations: more memcpy under the hood vs single bytes copy non-interruptible sleep (LockSupport.parkNanos) off heap allocation You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/activemq-artemis timed_buffer_reverted Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1403.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1403 commit 9dbeadcbc96cf3e551be95c12ea1d1fb83823e6f Author: Francesco Nigro <nigro.fra@gmail.com> Date: 2017-07-17T15:35:38Z ARTEMIS-1294 Reverted TimedBuffer timeout policy
          githubbot ASF GitHub Bot added a comment -

          GitHub user franz1981 opened a pull request:

          https://github.com/apache/activemq-artemis/pull/1404

          ARTEMIS-1294 Reverted TimedBuffer timeout policy

          (cherry picked from commit 9dbeadcbc96cf3e551be95c12ea1d1fb83823e6f)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/franz1981/activemq-artemis 1.x_timed_buffer_reverted

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/1404.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1404


          commit 65d5decf61af633202a630ed02c6acb5da0badb9
          Author: Francesco Nigro <nigro.fra@gmail.com>
          Date: 2017-07-17T15:35:38Z

          ARTEMIS-1294 Reverted TimedBuffer timeout policy

          (cherry picked from commit 9dbeadcbc96cf3e551be95c12ea1d1fb83823e6f)


          githubbot ASF GitHub Bot added a comment - GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1404 ARTEMIS-1294 Reverted TimedBuffer timeout policy (cherry picked from commit 9dbeadcbc96cf3e551be95c12ea1d1fb83823e6f) You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/activemq-artemis 1.x_timed_buffer_reverted Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1404 commit 65d5decf61af633202a630ed02c6acb5da0badb9 Author: Francesco Nigro <nigro.fra@gmail.com> Date: 2017-07-17T15:35:38Z ARTEMIS-1294 Reverted TimedBuffer timeout policy (cherry picked from commit 9dbeadcbc96cf3e551be95c12ea1d1fb83823e6f)

          Commit 3dc9566fb66b31729c3e04a8d06ff391a8c850b4 in activemq-artemis's branch refs/heads/master from nigro.fra@gmail.com
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3dc9566 ]

          ARTEMIS-1294 Reverted TimedBuffer timeout policy

          jira-bot ASF subversion and git services added a comment - Commit 3dc9566fb66b31729c3e04a8d06ff391a8c850b4 in activemq-artemis's branch refs/heads/master from nigro.fra@gmail.com [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3dc9566 ] ARTEMIS-1294 Reverted TimedBuffer timeout policy

          Commit ad372ec98e0d8e5765eef56883ea29b10768c70e in activemq-artemis's branch refs/heads/master from Clebert Suconic
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=ad372ec ]

          ARTEMIS-1294 Using older sleep on TimedBuffer

          And also adding test

          jira-bot ASF subversion and git services added a comment - Commit ad372ec98e0d8e5765eef56883ea29b10768c70e in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=ad372ec ] ARTEMIS-1294 Using older sleep on TimedBuffer And also adding test
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/1403

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1403

          Commit 38cd0cd9f4a4b2a55a3eb3d9514e52bcb6687da5 in activemq-artemis's branch refs/heads/1.x from nigro.fra@gmail.com
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=38cd0cd ]

          ARTEMIS-1294 Reverted TimedBuffer timeout policy

          (cherry picked from commit 3dc9566fb66b31729c3e04a8d06ff391a8c850b4)

          jira-bot ASF subversion and git services added a comment - Commit 38cd0cd9f4a4b2a55a3eb3d9514e52bcb6687da5 in activemq-artemis's branch refs/heads/1.x from nigro.fra@gmail.com [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=38cd0cd ] ARTEMIS-1294 Reverted TimedBuffer timeout policy (cherry picked from commit 3dc9566fb66b31729c3e04a8d06ff391a8c850b4)

          Commit b6b5b4caa7c97e28a840fb29d33c7d7b7410eb74 in activemq-artemis's branch refs/heads/1.x from Clebert Suconic
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b6b5b4c ]

          ARTEMIS-1294 Using older sleep on TimedBuffer

          And also adding test

          (cherry picked from commit ad372ec98e0d8e5765eef56883ea29b10768c70e)

          jira-bot ASF subversion and git services added a comment - Commit b6b5b4caa7c97e28a840fb29d33c7d7b7410eb74 in activemq-artemis's branch refs/heads/1.x from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b6b5b4c ] ARTEMIS-1294 Using older sleep on TimedBuffer And also adding test (cherry picked from commit ad372ec98e0d8e5765eef56883ea29b10768c70e)
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on the issue:

          https://github.com/apache/activemq-artemis/pull/1404

          can you close this please? I cherry-picked manually

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1404 can you close this please? I cherry-picked manually
          githubbot ASF GitHub Bot added a comment -

          Github user franz1981 closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/1404

          githubbot ASF GitHub Bot added a comment - Github user franz1981 closed the pull request at: https://github.com/apache/activemq-artemis/pull/1404

          People

            nigro.fra@gmail.com Francesco Nigro
            nigro.fra@gmail.com Francesco Nigro
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: