Uploaded image for project: 'ActiveMQ Artemis'
  1. ActiveMQ Artemis
  2. ARTEMIS-1257

ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.5.5, 2.1.0
    • 2.2.0
    • None
    • None

    Description

      According to the JCA specification [1] - Chapter 20, Packaging Requirements, 20-31 - configuration properties for the Resource adapter should be declared with boxed types.

      [1] http://download.oracle.com/otndocs/jcp/connector_architecture-1.6-fr-eval-oth-JSpec/

      Attachments

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user xstefank opened a pull request:

          https://github.com/apache/activemq-artemis/pull/1371

          ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq-…

          …ra when pooled connection factory rebalance-connections is set to true

          ARTEMIS: https://issues.apache.org/jira/browse/ARTEMIS-1257

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/1371.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1371


          commit 4420b72b1946d9d61f454fdf8b74ba4b4bb44905
          Author: xstefank <xstefank122@gmail.com>
          Date: 2017-06-27T10:45:24Z

          ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true


          githubbot ASF GitHub Bot added a comment - GitHub user xstefank opened a pull request: https://github.com/apache/activemq-artemis/pull/1371 ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq- … …ra when pooled connection factory rebalance-connections is set to true ARTEMIS: https://issues.apache.org/jira/browse/ARTEMIS-1257 You can merge this pull request into a Git repository by running: $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1371 commit 4420b72b1946d9d61f454fdf8b74ba4b4bb44905 Author: xstefank <xstefank122@gmail.com> Date: 2017-06-27T10:45:24Z ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true
          githubbot ASF GitHub Bot added a comment -

          GitHub user xstefank opened a pull request:

          https://github.com/apache/activemq-artemis/pull/1374

          ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq-…

          …ra when pooled connection factory rebalance-connections is set to true

          ARTEMIS: https://issues.apache.org/jira/browse/ARTEMIS-1257

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257-1.x

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/1374.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1374


          commit fa6b366f12cb12686747089be6748b1f7744325c
          Author: xstefank <xstefank122@gmail.com>
          Date: 2017-06-27T12:12:24Z

          ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true


          githubbot ASF GitHub Bot added a comment - GitHub user xstefank opened a pull request: https://github.com/apache/activemq-artemis/pull/1374 ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq- … …ra when pooled connection factory rebalance-connections is set to true ARTEMIS: https://issues.apache.org/jira/browse/ARTEMIS-1257 You can merge this pull request into a Git repository by running: $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257 -1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1374.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1374 commit fa6b366f12cb12686747089be6748b1f7744325c Author: xstefank <xstefank122@gmail.com> Date: 2017-06-27T12:12:24Z ARTEMIS-1257 IJ020017: Invalid archive: file://RaActivatoractivemq-ra when pooled connection factory rebalance-connections is set to true
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on a diff in the pull request:

          https://github.com/apache/activemq-artemis/pull/1374#discussion_r124260574

          — Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java —
          @@ -623,11 +623,11 @@ public void setUseLocalTx(final Boolean localTx)

          { this.localTx = localTx; }
          • public boolean isRebalanceConnections() {
            + public Boolean isRebalanceConnections() {
              • End diff –

          ??? how come this would be an issue? how to replictate it? have a test?

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1374#discussion_r124260574 — Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java — @@ -623,11 +623,11 @@ public void setUseLocalTx(final Boolean localTx) { this.localTx = localTx; } public boolean isRebalanceConnections() { + public Boolean isRebalanceConnections() { End diff – ??? how come this would be an issue? how to replictate it? have a test?
          githubbot ASF GitHub Bot added a comment -

          Github user xstefank commented on a diff in the pull request:

          https://github.com/apache/activemq-artemis/pull/1374#discussion_r124274905

          — Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java —
          @@ -623,11 +623,11 @@ public void setUseLocalTx(final Boolean localTx)

          { this.localTx = localTx; }
          • public boolean isRebalanceConnections() {
            + public Boolean isRebalanceConnections() {
              • End diff –

          @clebertsuconic there is a JBEAP issue associated: https://issues.jboss.org/browse/JBEAP-11776 ; Fix is only needed for this reason. I am not sure how to handle such case.

          githubbot ASF GitHub Bot added a comment - Github user xstefank commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1374#discussion_r124274905 — Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java — @@ -623,11 +623,11 @@ public void setUseLocalTx(final Boolean localTx) { this.localTx = localTx; } public boolean isRebalanceConnections() { + public Boolean isRebalanceConnections() { End diff – @clebertsuconic there is a JBEAP issue associated: https://issues.jboss.org/browse/JBEAP-11776 ; Fix is only needed for this reason. I am not sure how to handle such case.
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on the issue:

          https://github.com/apache/activemq-artemis/pull/1374

          Well.. even if the change is valid.. we need to understand what is the issue..

          perhaps the type needs to match the method?

          on which case the description of the JIRA is wrong... it would be something generic not tight to Wildfly.

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1374 Well.. even if the change is valid.. we need to understand what is the issue.. perhaps the type needs to match the method? on which case the description of the JIRA is wrong... it would be something generic not tight to Wildfly.
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on the issue:

          https://github.com/apache/activemq-artemis/pull/1374

          there are a lot of other booleans on the ActivactionSpec.. what if you set shareSubscriptions to true for instance?

          I'm not convinced of an issue in Artemis yet.

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1374 there are a lot of other booleans on the ActivactionSpec.. what if you set shareSubscriptions to true for instance? I'm not convinced of an issue in Artemis yet.
          githubbot ASF GitHub Bot added a comment -

          Github user clebertsuconic commented on the issue:

          https://github.com/apache/activemq-artemis/pull/1374

          At least the JIRA here is wrong.. this could be the cause of a Wildfly issue.. but the issue is there.. a mismatch somewhere. you should rename this to matching boolean property to Boolean as specified somewhere else.. I'm fine with this... but the file:// error won't translate here.

          githubbot ASF GitHub Bot added a comment - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1374 At least the JIRA here is wrong.. this could be the cause of a Wildfly issue.. but the issue is there.. a mismatch somewhere. you should rename this to matching boolean property to Boolean as specified somewhere else.. I'm fine with this... but the file:// error won't translate here.
          githubbot ASF GitHub Bot added a comment -

          Github user xstefank closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/1371

          githubbot ASF GitHub Bot added a comment - Github user xstefank closed the pull request at: https://github.com/apache/activemq-artemis/pull/1371
          githubbot ASF GitHub Bot added a comment -

          Github user xstefank closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/1374

          githubbot ASF GitHub Bot added a comment - Github user xstefank closed the pull request at: https://github.com/apache/activemq-artemis/pull/1374
          githubbot ASF GitHub Bot added a comment -

          GitHub user xstefank opened a pull request:

          https://github.com/apache/activemq-artemis/pull/1414

          ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for a…

          …ttributes values according to the JCA specification

          https://issues.apache.org/jira/browse/ARTEMIS-1257

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/1414.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1414


          commit 1b9f19a20af7b124c25ac195d4dda1f1c42581ae
          Author: xstefank <xstefank122@gmail.com>
          Date: 2017-07-20T10:03:08Z

          ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification


          githubbot ASF GitHub Bot added a comment - GitHub user xstefank opened a pull request: https://github.com/apache/activemq-artemis/pull/1414 ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for a… …ttributes values according to the JCA specification https://issues.apache.org/jira/browse/ARTEMIS-1257 You can merge this pull request into a Git repository by running: $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1414.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1414 commit 1b9f19a20af7b124c25ac195d4dda1f1c42581ae Author: xstefank <xstefank122@gmail.com> Date: 2017-07-20T10:03:08Z ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification
          githubbot ASF GitHub Bot added a comment -

          GitHub user xstefank opened a pull request:

          https://github.com/apache/activemq-artemis/pull/1415

          ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for a…

          …ttributes values according to the JCA specification

          https://issues.apache.org/jira/browse/ARTEMIS-1257

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257-1.x

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/activemq-artemis/pull/1415.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1415


          commit 40d63773f5be500d45a2ce4f6007e25252f9a8f5
          Author: xstefank <xstefank122@gmail.com>
          Date: 2017-07-20T10:03:08Z

          ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification


          githubbot ASF GitHub Bot added a comment - GitHub user xstefank opened a pull request: https://github.com/apache/activemq-artemis/pull/1415 ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for a… …ttributes values according to the JCA specification https://issues.apache.org/jira/browse/ARTEMIS-1257 You can merge this pull request into a Git repository by running: $ git pull https://github.com/xstefank/jboss-activemq-artemis ARTEMIS-1257 -1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1415 commit 40d63773f5be500d45a2ce4f6007e25252f9a8f5 Author: xstefank <xstefank122@gmail.com> Date: 2017-07-20T10:03:08Z ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification
          githubbot ASF GitHub Bot added a comment -

          Github user xstefank commented on the issue:

          https://github.com/apache/activemq-artemis/pull/1414

          retest this please

          githubbot ASF GitHub Bot added a comment - Github user xstefank commented on the issue: https://github.com/apache/activemq-artemis/pull/1414 retest this please
          githubbot ASF GitHub Bot added a comment -

          Github user xstefank commented on the issue:

          https://github.com/apache/activemq-artemis/pull/1415

          retest this please

          githubbot ASF GitHub Bot added a comment - Github user xstefank commented on the issue: https://github.com/apache/activemq-artemis/pull/1415 retest this please
          githubbot ASF GitHub Bot added a comment -

          Github user xstefank commented on the issue:

          https://github.com/apache/activemq-artemis/pull/1415

          retest this please

          githubbot ASF GitHub Bot added a comment - Github user xstefank commented on the issue: https://github.com/apache/activemq-artemis/pull/1415 retest this please

          Commit 553043393e0665795725b2a0f9de1c4137d6b2ef in activemq-artemis's branch refs/heads/master from xstefank
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5530433 ]

          ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification

          jira-bot ASF subversion and git services added a comment - Commit 553043393e0665795725b2a0f9de1c4137d6b2ef in activemq-artemis's branch refs/heads/master from xstefank [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5530433 ] ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/1415

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1415
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/activemq-artemis/pull/1414

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1414

          Commit e2d9e1bb63e58e9c84fb109abf0767f383c5614f in activemq-artemis's branch refs/heads/1.x from xstefank
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e2d9e1b ]

          ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification

          (cherry picked from commit 553043393e0665795725b2a0f9de1c4137d6b2ef)

          jira-bot ASF subversion and git services added a comment - Commit e2d9e1bb63e58e9c84fb109abf0767f383c5614f in activemq-artemis's branch refs/heads/1.x from xstefank [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e2d9e1b ] ARTEMIS-1257 ActiveMQActivationSpec.java should use boxed types for attributes values according to the JCA specification (cherry picked from commit 553043393e0665795725b2a0f9de1c4137d6b2ef)

          Commit 08d8c08ed3825d53666d774d0b919b6cd2caa545 in activemq-artemis's branch refs/heads/master from Clebert Suconic
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=08d8c08 ]

          ARTEMIS-1257 Fixing hashCode

          ResourceAdapterTest had a few failures with a NPE

          jira-bot ASF subversion and git services added a comment - Commit 08d8c08ed3825d53666d774d0b919b6cd2caa545 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=08d8c08 ] ARTEMIS-1257 Fixing hashCode ResourceAdapterTest had a few failures with a NPE

          Commit 5298a3979b553e47becd02fb1ddd802b1a0c4633 in activemq-artemis's branch refs/heads/1.x from Clebert Suconic
          [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5298a39 ]

          ARTEMIS-1257 Fixing hashCode

          ResourceAdapterTest had a few failures with a NPE

          (cherry picked from commit 08d8c08ed3825d53666d774d0b919b6cd2caa545)

          jira-bot ASF subversion and git services added a comment - Commit 5298a3979b553e47becd02fb1ddd802b1a0c4633 in activemq-artemis's branch refs/heads/1.x from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5298a39 ] ARTEMIS-1257 Fixing hashCode ResourceAdapterTest had a few failures with a NPE (cherry picked from commit 08d8c08ed3825d53666d774d0b919b6cd2caa545)

          People

            mstefank Martin Stefanko
            mstefank Martin Stefanko
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: