[ARTEMIS-1001] slow-consumer-check-period is in minutes but behaves like with seconds

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 1.5.3
• Component/s: Broker
• Assignee: Unassigned
• Reporter: Miroslav Novak
• Created: 27/Feb/17 11:55
• Updated: 08/Mar/17 14:08
• Resolved: 27/Feb/17 15:11

Description

Attribute slow-consumer-check-period is in minutes but {{SlowConsumerReaperRunnable} thread is scheduled as it's configured with seconds.

Problem is in QueueImpl.scheduleSlowConsumerReaper method:

slowConsumerReaperFuture = scheduledExecutor.scheduleWithFixedDelay(slowConsumerReaperRunnable, settings.getSlowConsumerCheckPeriod(), settings.getSlowConsumerCheckPeriod(), TimeUnit.SECONDS);

contains TimeUnit.SECONDS instead of TimeUnit.MINUTES.

I tried to debug it and can see that settings.getSlowConsumerCheckPeriod() returns 1 which is in minutes. This seems to be easy fix.

Issue Links

• relates to: ARTEMIS-504 Inconsistent time unit on scheduling slow consumer reaper thread between documentation and source code
• links to: GitHub Pull Request #1052