[ARROW-9698] [C++] Revert "Add -NDEBUG flag to arrow.pc"

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: C++, Packaging
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/25754
• Assignee: Brian Dunlay
• Reporter: Brian Dunlay
• Created: 12/Aug/20 03:20
• Updated: 11/Jan/23 08:08
• Resolved: 13/Aug/20 12:35

Description

ARROW-2275 introduced a `#ifndef NDEBUG` check around a function which caused the function to to be omitted during release builds.

As a workaround, ARROW-2313 added -DNDEBUG flags to the pkg-config cmake definition so that anyone using the release build of the package would not run into any issues with the missing code. As a result of this change,`pkg-config arrow --cflags` results in -DNDEBUG being added as a compiler flag, forcing itself on the downstream project whenever the dependency is located using pkg-config --.

The original `#ifndef NDEBUG` change was reverted with ARROW-2316, but the workaround in ARROW-2313 remains.

I am proposing to revert the workaround in ARROW-2313 so that downstream projects may link against the release build of arrow without adopting the -DNDEBUG flag unnecessarily.

Issue Links

• links to: GitHub Pull Request #7939