[ARROW-9541] [C++] CMakeLists requires UTF8PROC_STATIC when building static library

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 2.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/25608
• Assignee: Tanguy Fautre
• Reporter: Tanguy Fautre
• Created: 22/Jul/20 10:40
• Updated: 11/Jan/23 08:07
• Resolved: 03/Aug/20 19:23

Description

Arrow does not correctly link with utf8proc if UTF8PROC_STATIC is not specified when creating a static library, the library will contain unresolved symbols to a DLL import library.

AFAIK this only happens on Windows (Visual Studio) but in theory the flag should probably be specified for all platform. I suspect that in practice only MSVC is impacted. There is already an existing section in `CMakeLists.txt` covering this problem for Arrow itself.

See https://github.com/microsoft/vcpkg/pull/12537/files for an example patch. In particular (line 149 of CMakeLists.txt):

 if(ARROW_BUILD_STATIC AND WIN32)
   target_compile_definitions(arrow_static PUBLIC ARROW_STATIC)
+  if(ARROW_WITH_UTF8PROC)
+    target_compile_definitions(arrow_static PUBLIC UTF8PROC_STATIC)
+  endif()
 endif()

Issue Links

• links to: GitHub Pull Request #7818