[ARROW-9463] [Go] The writer is double closed in TestReadWrite

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.17.1
• Fix Version/s: 2.0.0
• Component/s: Go
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/25536
• Assignee: Unassigned
• Reporter: FredGan
• Created: 14/Jul/20 12:59
• Updated: 11/Jan/23 08:07
• Resolved: 04/Aug/20 13:06

Description

The writer in the test case 'TestReadWrite' is double closed.

w, err := NewWriter(f, recs[0].Schema())
if err != nil {
   t.Fatal(err)
}
defer w.Close()     // <= Here

for i, rec := range recs {
   err = w.Write(rec)
   if err != nil {
      t.Fatalf("could not write record[%d] to JSON: %v", i, err)
   }
}

err = w.Close()    // <= Here
if err != nil {
   t.Fatalf("could not close JSON writer: %v", err)
}

The 'defer w.Close()' is redundant, which makes one more ']}' in the end of the output json file .

 

 

Issue Links

• links to: GitHub Pull Request #7754