Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-8969

[C++] Reduce generated code in compute/kernels/scalar_compare.cc

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • C++

    Description

      We are instantiating multiple versions of templates in this module for cases that, byte-wise, do the exact same comparison. For example:

      • For equals, not_equals, we can use the same 32-bit/64-bit comparison kernels for signed int / unsigned int / floating point types of the same byte width
      • TimestampType can reuse int64 kernels, similarly for other date/time types
      • BinaryType/StringType can share kernels

      etc.

      Attachments

        Issue Links

          Activity

            People

              wesm Wes McKinney
              wesm Wes McKinney
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 7h 10m
                  7h 10m