Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-8933

[C++] Reduce generated code in vector_hash.cc

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • C++

    Description

      Since hashing doesn't need to know about logical types, we can do the following:

      • Use same generated code for both BinaryType and StringType (and LargeBinary/LargeString)
      • Use same generated code for primitive types having the same byte width

      These two changes should reduce binary size and improve compilation speed

      Attachments

        Issue Links

          Activity

            People

              wesm Wes McKinney
              wesm Wes McKinney
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m