[ARROW-8933] [C++] Reduce generated code in vector_hash.cc

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/17200
• Assignee: Wes McKinney
• Reporter: Wes McKinney
• Created: 25/May/20 13:55
• Updated: 11/Jan/23 08:03
• Resolved: 24/Jun/20 03:29

Description

Since hashing doesn't need to know about logical types, we can do the following:

• Use same generated code for both BinaryType and StringType (and LargeBinary/LargeString)
• Use same generated code for primitive types having the same byte width

These two changes should reduce binary size and improve compilation speed

Issue Links

• is a child of: ARROW-8894 [C++] C++ array kernels framework and execution buildout (umbrella issue)
• is related to: ARROW-8970 [C++] Reduce shared library / binary code size (umbrella issue)
• links to: GitHub Pull Request #7528